Scott on Writing

Musings on technical writing...

Your Daily Tip to Save Yourself 15 Minutes of Wasted Time

Thought I'd jot this donw - hopefully someone out there will read it and save the 15 minutes I lost to working on this little “gotcha” problem.

Scenario: You have a DataGrid with two columns.  The first is a BoundColumn, the second a TemplateColumn.  In the TemplateColumn you have a RadioButtonList.  The idea is to have the user select precisely one option from the second column for each item in the first one.  Basically, the DataGrid markup looks like:

<asp:DataGrid ...>
   <Columns>
      <asp:BoundColumn ... />
      <asp:TemplateColumn>
         <ItemTemplate>
             <asp:RadioButtonList id=”radList” ... />
         </ItemTemplate>
      </asp:TemplateColumn>
   </Columns>
</asp:DataGrid>

Now, this RadioButtonList needs to be bound to a list of options.  Since the options are the same for all items in the DataGrid (and therefore not specific on the particular row), you figure that you'll use the DataGrid's ItemCreated event to do this.  (FIRST MISTAKE!)  The event handler looks something like:

Sub MyDataGrid_ItemCreated(...) Handles MyDataGrid.ItemCreated
   If e.Item.ItemType = ... Then
      'Get a reference to the RadioButtonList
      Dim radList as RadioButtonList = CType(...)

      'Bind the data
      radList.DataSource = ...
      radList.DataBind()
   End If
End Sub

The above will work just fine, although it is a bit inefficient (more on that later).  Now, if you were to see the DataGrid, you'd see a series of rows with the second column in each row with a set of radio buttons.  However, no radio button is selected by default.  Ok, easy enough, go and add radList.SelectedIndex = 0 right after the radList.DataBind() call, right?  Well, you'd think that work, but it doesn't.  No error, of course, just no selected radio button.

Now, if you are like me, you spend the next 15 minutes thinking about this, opening Reflector, reading the docs, and being generally unproductive.

If you want to waste less time, you would simply move this code to the ItemDataBound event rather than ItemCreated.  After ItemCreated, the DataGrid assigns the DataSource record to the DataItem property of the current DataGridItem (e.Item) and then calls the DataBind() method of that DataGridItem.  The DataGridItem propogates the DataBind() call down to its child controls, meaning the RadioButtonList will have its OnDataBinding event fire.  What happens there?  Well, it sees that the DataSource for the RadioButtonList is not null, so it clears out the RadioButtonList items, and rebinds the data!  This, of course, has the negative side-effect of clearing out the SelectedIndex setting.

Solution: anytime you find yourself calling DataBind() for a Web control that exists in a TemplateColumn of the DataGrid, make sure you are doing so in the DataGrid's ItemDataBound event, otherwise the data will be bound twice to the Web control, which will not only be less efficient, but might have negative side-effects, as seen here.

posted on Tuesday, July 20, 2004 12:24 PM

Feedback

# Scott Mitchell's Time Saver 7/27/2004 7:45 PM OdeToCode News

# Scott Mitchell's Time Saver 7/29/2004 6:57 AM OdeToCode News

# re: Your Daily Tip to Save Yourself 15 Minutes of Wasted Time 2/8/2006 3:51 AM Damon Birch

Excellent

Just wasted a day on this, not just 15 minutes!


Thankyou

Title:  
Name:  
Url:
Protected by Clearscreen.SharpHIPEnter the code you see:
Comments   

Add To Your Reader

My Links

Archives

Post Categories

 

I am a Microsoft MVP for ASP.NET.
I am an ASPInsider.
<May 2008>
SMTWTFS
27282930123
45678910
11121314151617
18192021222324
25262728293031
1234567

Comment Stats

DayTotal% of Total
Sunday 1866.8%
Monday 37913.9%
Tuesday 45316.7%
Wednesday 50418.5%
Thursday 53519.7%
Friday 49418.2%
Saturday 1666.1%
Total 2717100.0%

Hour1Total% of Total
12:00 AM 652.4%
1:00 AM 682.5%
2:00 AM 622.3%
3:00 AM 742.7%
4:00 AM 572.1%
5:00 AM 1033.8%
6:00 AM 1084.0%
7:00 AM 1585.8%
8:00 AM 1716.3%
9:00 AM 1475.4%
10:00 AM 1716.3%
11:00 AM 1816.7%
12:00 PM 1886.9%
1:00 PM 1696.2%
2:00 PM 1605.9%
3:00 PM 1324.9%
4:00 PM 1073.9%
5:00 PM 923.4%
6:00 PM 913.3%
7:00 PM 963.5%
8:00 PM 833.1%
9:00 PM 782.9%
10:00 PM 792.9%
11:00 PM 772.8%
Total 2717100.0%

Comments by Blog Entry Date/Time

Day Entry MadeAvg.Total
Sunday 5.54144
Monday 5.22339
Tuesday 4.28419
Wednesday 7.67637
Thursday 6.90607
Friday 5.48411
Saturday 5.33160
Total 5.842717

Hour1 Entry MadeAvg.Total
12:00 AM 5.0035
1:00 AM 1.002
5:00 AM 0.000
7:00 AM 7.0035
8:00 AM 5.35107
9:00 AM 6.32278
10:00 AM 6.47246
11:00 AM 4.41181
12:00 PM 6.88330
1:00 PM 3.00111
2:00 PM 5.41222
3:00 PM 8.64285
4:00 PM 4.0589
5:00 PM 5.92154
6:00 PM 4.52113
7:00 PM 9.67174
8:00 PM 9.80147
9:00 PM 5.05111
10:00 PM 5.4265
11:00 PM 4.5732
Total 5.842717

Learn More About Comment Stats
1 - All times GMT -8...


Blog Stats

Favorite Web Sites

My Books

My MSDN Articles